Fix theme based styling for WindowCommands and WindowButtonCommands #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enumeration helps us to check for light and dark themes.
…ndowButtonCommands - Add new brush `MahApps.Brushes.WindowButtonCommands.HoverBackground` - Add new style `MahApps.Styles.WindowCommands.Base` - Derive style `MahApps.Styles.WindowCommands.Clean` from `MahApps.Styles.WindowCommands.Base` - Add new style `MahApps.Styles.WindowButtonCommands.Base` - Derive style `MahApps.Styles.WindowButtonCommands.Clean` from `MahApps.Styles.WindowButtonCommands.Base` - `MahApps.Styles.MetroWindow.Clean` style doesn't set the `OverrideDefaultWindowCommandsBrush` to `MahApps.Brushes.Black` (it's not necessary anymore) - Add new styles `MahApps.Styles.Button.CleanWindow.Light` and `MahApps.Styles.Button.CleanWindow.Dark` - Fix disabled brush at `WindowCommands` and `WindowButtonCommands` - Set the pressed background of the Min/Max/Restore/Close buttons to `MahApps.Brushes.AccentBase` and the foreground to `MahApps.Brushes.IdealForeground` - Do not set the theme for WindowCommands and WindowButtonCommands by the Foreground. Instead look for the current theme of the application, window or flyout.
- Add new style `MahApps.Styles.Button.CleanWindow.Close.Light.Win10` - Add new style `MahApps.Styles.Button.CleanWindow.Close.Dark.Win10` - Add new style `MahApps.Styles.WindowButtonCommands.Clean.Win10`
Use PreviewMouseLeftButtonDown instead Click event to allow losing the focus also inside WindowCommands. Set the BorderThickness of the ListBox at the popup to 1 and don't show a focused visual.
- Add a new style `MahApps.Styles.SplitButton.Button.WindowCommands` - Add a new style `MahApps.Styles.SplitButton.ButtonArrow.WindowCommands` - Add a new style `MahApps.Styles.SplitButton.WindowCommands` which will be used for all SplitButton inside WindowCommands
|
Hi @punker76 many thanks it looks really promissing. I think many people will have a benefit of this. Meanwhile I created a Happy coding |
|
@timunie 😉
|
- Add a new style `MahApps.Styles.DropDownButton.Button.WindowCommands` - Add a new style `MahApps.Styles.DropDownButton.WindowCommands` which will be used for all DropDownButton inside WindowCommands
|
@punker76 I am just too slow to competite with you. Thanks Happy updating and happy Halloween |
|
@timunie Improved overflow WindowCommands
|
punker76
deleted the
3623_Fix_styling_for_WindowCommands_WindowButtonCommands
branch
amkuchta
pushed a commit
to amkuchta/MahApps.Metro
that referenced
this pull request
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
MahApps.Brushes.WindowButtonCommands.HoverBackgroundMahApps.Styles.WindowCommands.BaseMahApps.Styles.WindowCommands.CleanfromMahApps.Styles.WindowCommands.BaseMahApps.Styles.WindowButtonCommands.BaseMahApps.Styles.WindowButtonCommands.CleanfromMahApps.Styles.WindowButtonCommands.BaseMahApps.Styles.MetroWindow.Cleanstyle doesn't set theOverrideDefaultWindowCommandsBrushtoMahApps.Brushes.Black(it's not necessary anymore)MahApps.Styles.Button.CleanWindow.LightandMahApps.Styles.Button.CleanWindow.DarkWindowCommandsandWindowButtonCommandsMahApps.Brushes.AccentBaseand the foreground toMahApps.Brushes.IdealForegroundMahApps.Styles.Button.CleanWindow.Close.Light.Win10MahApps.Styles.Button.CleanWindow.Close.Dark.Win10MahApps.Styles.WindowButtonCommands.Clean.Win10SplitButtonSplitButtonstyle for WindowCommandsMahApps.Styles.SplitButton.Button.WindowCommandsMahApps.Styles.SplitButton.ButtonArrow.WindowCommandsMahApps.Styles.SplitButton.WindowCommandswhich will be used for all SplitButton inside WindowCommandsMahApps.Styles.DropDownButton.Button.WindowCommandsMahApps.Styles.DropDownButton.WindowCommandswhich will be used for all DropDownButton inside WindowCommandsClosed Issues
Closes #3623
Closes #2560
Closes #3447