Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wraped the demo pages in a scrollviewer for a better user expierience #3523

Merged
merged 4 commits into from
Jun 5, 2019

Conversation

timunie
Copy link
Collaborator

@timunie timunie commented Jun 5, 2019

Added scollviewer wirh Scrollbarvisibility set to Auto, except for the item-controls. There the vertical scrollviewer is set to disabled to prevent an infinite long page

Describe the changes you have made to improve this project

Added scollviewer wirh Scrollbarvisibility set to Auto, except for the item-controls. There the vertical scrollviewer is set to disabled to prevent an infinite long page

Unit test

I am sorry, but I didn't understand what to do here yet.

Additional context

Add any other context or screenshots about the feature request here.
image

Closed Issues
Closes #3521

Added scollviewer wirh Scrollbarvisibility set to Auto, except for the item-controls. There the vertical scrollviewer is set to disabled to prevent an infinite long page
@punker76 punker76 added this to the 2.0.0 milestone Jun 5, 2019
…rollViewer

The workaround would be to bind the Documents PageWidth to the RichTextBox's ActualWidth
@punker76 punker76 merged commit a3f7a48 into MahApps:develop Jun 5, 2019
@punker76
Copy link
Member

punker76 commented Jun 5, 2019

@timunie your changes have been merged, thanks for your contribution 👍

@timunie timunie deleted the DemoAppScrollviewer branch June 5, 2019 21:30
@timunie
Copy link
Collaborator Author

timunie commented Jun 5, 2019

@punker76 Thank you for your fixes. I didn't make much 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Demo App should have a scrollviewer around the sample pages
2 participants