Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved #2820 #2822

Closed
wants to merge 26 commits into from
Closed

Resolved #2820 #2822

wants to merge 26 commits into from

Conversation

RyadaProductions
Copy link

Reapplied bug fix from d70c3c9.

What changed?

Describe the changes you have made to improve this project.
Reapplied a bugfix for StickyWindow, which was added in 2013 but removed late 2015.
Normal users should not notice any change.

Closed issues.
#2820

@nighthound
Copy link

Hi, I'm curious why this is on hold for more than a year. Is window snapping functionality something that will be included in 2.0 and hence not being merged?

@thoemmi
Copy link
Collaborator

thoemmi commented Dec 4, 2018

@punker76 Is there a chance that this PR will be merged? This issue was reported to StickyWindows too: thoemmi/StickyWindows#7

@RyadaProductions
Copy link
Author

If there is anything I must do to make the merge possible please let me know. As I am wondering why its not merged yet.

@punker76
Copy link
Member

punker76 commented Dec 4, 2018

@thoemmi I will look for it. First I must check why I changed this, because something needs this...

@punker76 punker76 added Bug and removed on hold labels Dec 5, 2018
@punker76 punker76 added this to the 2.0.0 milestone Dec 5, 2018
@punker76 punker76 closed this in 6893565 Dec 5, 2018
@punker76
Copy link
Member

punker76 commented Dec 5, 2018

@thoemmi @RyadaProductions I found the issue and pr which introduces the change #2324 PR #2326. But, I could not reproduce this issue with the latest source. So I added your changes.

@thoemmi If I set StickOnMove to true then I can not move a maximized Window. This happens without MahApps too, so is this a normal behabior? If I set it to false then I can do this.

@thoemmi
Copy link
Collaborator

thoemmi commented Dec 5, 2018

Thanks @punker76. I'll check that "StickOnMove issue" (I hardly do any GUI work anymore, that's why I got so quiet in the recent past)

@JobaDiniz
Copy link

JobaDiniz commented Dec 5, 2018

Hi, is it possible to release this fix into a new version of 1.X? Maybe 1.6.6? I need this functionality into 1.6.x, moving to 2.X is a major breaking change for me, as we have developed a full IDE relying on MahApps + Gemini and 2.X breaks several things.

@punker76 punker76 added Bug Fix and removed Bug labels Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants