Floating watermarks now trigger better #2236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2225
List of changes:
PART_FloatingMessageContainer
grid is now aContentControl
because the layout system for ContentControl is way simpler and therefore faster. Also, the grid wasn't necessary.DataTrigger
s. This system now consists of aMultiDataTrigger
with two conditions, which both must be satisfied:TextBoxHelper.Watermark
has been dropped, because there are no 'negative' DataTriggers. This brings me to the next change:Height
; it is nowMaxHeight
. If the watermark is not set, the TextBlock will not take any space because it uses an addedMetroAutoCollapsingTextBlock
style, which is based onMetroTextBlock
and will automatically collapse when the text property is empty.