Some progressbar dialog fixes #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elled event , also made IsCancelled read only Note : this isn't a breaking change , only the read only properties might be breaking
| /// Gets if the wrapped ProgressDialog is open. | ||
| /// </summary> | ||
| public bool IsOpen { get { return m_isopen; } } | ||
| private bool m_isopen; |
There was a problem hiding this comment.
why this change? IsOpen is already marked as obsolete, so this is not necessary...
There was a problem hiding this comment.
i use IsOpen to check if the dialog is visible so i close it programmatically , so it filled vs with warnings of it being obsolete
| /// <summary> | ||
| /// This event is raised when the associated <see cref="ProgressDialog"/> was cancelled by the user. | ||
| /// </summary> | ||
| public event EventHandler Cancelled; |
There was a problem hiding this comment.
Typical Americanism. Everywhere else in the world it's cancelled (with double l).
http://grammarist.com/spelling/cancel/
Though, sticking with one convention is best. (and it seems MS prefers us english :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think this is how progressbar dialog should be , removed the obsolete from IsOpen property and made it read only , also added cancelled event