support for multiple dialogs (fixes #1974) #2009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thoemmi i'm fine with this (little breaking) changes (maybe i must update my SimpleChildWindow). but you forgot the |
|
Shame on me 😳 I'll fix it. |
|
👍 |
punker76
added a commit
that referenced
this pull request
Jun 30, 2015
support for multiple dialogs (fixes #1974)
|
Much appreciated enhancement 👍 |
|
Motivated by selfishness ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple dialogs at once as requested in #1974. There can only be one active dialog, and there's no support for switching between dialogs. It's like a stack of dialogs.
I hope the changes are self-explanatory.
However, there's one breaking change: previously the
MetroWindow's template contained a part namedPART_MetroDialogContainer, now there are two parts namedPART_MetroActiveDialogContainerandPART_MetroInactiveDialogsContainer. When someone has created his own style forMetroWindowit will break.