creating a Task instance doesn't execute it #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
punker76
added a commit
that referenced
this pull request
Jun 21, 2015
creating a Task instance doesn't execute it
|
thx @thoemmi that makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of .NET 4.0 compatibility, MahApps.Metro can't use
Task.FromResult. However, just returningnew System.Threading.Tasks.Task(() => { })doesn't help, because it won't execute the task. Instead, you should use aTaskCompletionSource. Since both methods in question already ise a TCS, in the PR I moved their creations to an earlier point and re-used them.I noticed this issue when I tried to open two dialog at once, a continuation for the returned tasks never run.