Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toggling visibility on hamburger menu #3768

Closed
WPFAdvocate opened this issue Apr 2, 2020 · 2 comments · Fixed by #3782
Closed

Toggling visibility on hamburger menu #3768

WPFAdvocate opened this issue Apr 2, 2020 · 2 comments · Fixed by #3782
Labels
Feature Request
Milestone
2.0.0

Comments

@WPFAdvocate
Copy link

It would be nice to have a visibility open on hamburger menu items to hide from people that are not suppose to see instead of just it being disabled for certain users.
@WPFAdvocate WPFAdvocate changed the title Toggling visibility on hamburger meu Toggling visibility on hamburger menu Apr 2, 2020
@bNobo
Copy link

bNobo commented Apr 26, 2020 •
edited
Loading

I've started working on it and have a question: should Visibility property be added on HamburgerMenuItem or HamburgerMenuItemBase class? In the first case it won't be possible to hide or collapse a menu separator because HamburgerMenuSeparatorItem inherits directly from HamburgerMenuItemBase. Should the menu separator also be able to be hidden?

@timunie
Copy link
Collaborator

timunie commented Apr 26, 2020

Hi @bNobo
Consider this:

Item1
-----------
Item2
-----------
Item3

If you hide Item2 you would have two seperators. So in that case you must be able to hide the seperator as well.

That said please keep in mind that the primary goal is to get v2.0.0 released. this feature might get implemented later.

Happy coding
Tim

@bNobo bNobo mentioned this issue Apr 26, 2020
Merged
punker76 added a commit to bNobo/MahApps.Metro that referenced this issue Apr 28, 2020
@punker76
(MahAppsGH-3768) Add Visibility property to HambugerMenuItemBase
213117d 
(MahAppsGH-3768) Add Visibility property to HambugerMenuItemBase
punker76 added a commit to bNobo/MahApps.Metro that referenced this issue Apr 28, 2020
@punker76
(MahAppsGH-3768) Change Visibility property to IsVisible
b267a5f 
IMO IsVisible is the better way to say if an item should be shown or not. With the Visibility property you can set an item also to hide which means that the item is only hidden.
@punker76 punker76 added this to the 2.0.0 milestone Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Add IsVisible property to HambugerMenuItemBase bNobo/MahApps.Metro
4 participants
@punker76 @bNobo @timunie @WPFAdvocate