Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GroupBoxHelper as it supports also Expander #3633

Closed
timunie opened this issue Oct 7, 2019 · 0 comments · Fixed by #3636
Closed

Rename GroupBoxHelper as it supports also Expander #3633

timunie opened this issue Oct 7, 2019 · 0 comments · Fixed by #3636
Labels
Hacktoberfest
Milestone
2.0.0

Comments

@timunie
Copy link
Collaborator

timunie commented Oct 7, 2019

Is your feature request related to a problem? Please describe.
The GroupBoxHelper applies to GroupBox and Expander. So it should be renamed.

Describe the solution you'd like
Rename GroupBoxHelper to HeaderedControlHelper

Additional context
A PR will be published today.
@timunie timunie mentioned this issue Oct 7, 2019
Merged
@punker76 punker76 added this to the 2.0.0 milestone Oct 7, 2019
punker76 added a commit to timunie/MahApps.Metro that referenced this issue Oct 7, 2019
@punker76
(MahAppsGH-3633, MahAppsGH-3634) Renamed GroupBoxHelper and added a n…
ba63e0f 
…ew attached property for header background

- Rename GroupBoxHelper to HeaderedControlHelper
- Added attached property HeaderBackground
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest
Milestone
2.0.0
2 participants
@punker76 @timunie