Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HamburgerMenu - HamburgerVisibility "Collapsed" statement doesn't seem to work properly #3592

Closed
ghost opened this issue Aug 30, 2019 · 0 comments · Fixed by #3593
Closed

HamburgerMenu - HamburgerVisibility "Collapsed" statement doesn't seem to work properly #3592

ghost opened this issue Aug 30, 2019 · 0 comments · Fixed by #3593
Assignees
@punker76
Labels
Bug
Milestone
2.0.0

Comments

@ghost
Copy link

ghost commented Aug 30, 2019

Collapsed statement (to not be confused with Hidden one) in HamburgerVisibility hides the Hamburger itself, but the remaining space from it doesn't disappear as it should to, referring to Microsoft.

        <controls:HamburgerMenu x:Name="HamburgerMenu"
                                ...
                                HamburgerVisibility="Collapsed">
                                ...

So it leaves a gap on the panel:

  • MahApps.Metro 1.6.5
  • OS: Windows 7 SP1 x64
  • Visual Studio 2019 (16.0.29209.62)
  • .NET Framework 4.7.2
@ghost ghost changed the title HamburgerMenu - HamburgerVisibility collapsed statement doesn't seem to work properly HamburgerMenu - HamburgerVisibility "Collapsed" statement doesn't seem to work properly Aug 30, 2019
@punker76 punker76 added the Bug label Aug 30, 2019
@punker76 punker76 self-assigned this Aug 30, 2019
@punker76 punker76 added this to the 2.0.0 milestone Aug 30, 2019
punker76 added a commit that referenced this issue Aug 30, 2019
@punker76
(GH-3592) Fix HamburgerVisibility "Collapsed" state
4a8dcf7 
The height of the inner `PaneHeader` DockPanel was set to the HamburgerHeight. This is wrong because it'll already set by the inner `HamburgerButton`.
@punker76 punker76 mentioned this issue Aug 30, 2019
Merged
punker76 added a commit that referenced this issue Aug 30, 2019
@punker76
Merge pull request #3593 from MahApps/fix/GH-3592
99f8e18 
(GH-3592) Fix HamburgerVisibility "Collapsed" state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
Bug
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

(GH-3592) Fix HamburgerVisibility "Collapsed" state MahApps/MahApps.Metro
1 participant
@punker76