Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Naming Convention #3584

Closed
amkuchta opened this issue Aug 27, 2019 · 6 comments · Fixed by #3649
Closed

Font Naming Convention #3584

amkuchta opened this issue Aug 27, 2019 · 6 comments · Fixed by #3649
Labels
Breaking Change
Milestone
2.0.0

Comments

@amkuchta
Copy link
Contributor

amkuchta commented Aug 27, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.

Looking through the new naming conventions, Fonts are structured as follows:

  • FontFamily: MahApps.Fonts.[Family] (e.g. MahApps.Fonts.Header)
  • Font Sizes: MahApps.Sizes.Font.[Size] (e.g. MahApps.Sizes.Font.Header)

I think that this is namespacing is inconsistent, and that a small update could make things easier for other users to follow.

Describe the solution you'd like

I suggest updating to the following naming convention for consistency:

  • FontFamily: MahApps.Font.Family.[Family] (e.g. MahApps.Font.Family.Header)
  • Font Sizes: MahApps.Font.Size.[Size] (e.g. MahApps.Font.Size.Header)

This creates a more consistent (and therefore easier to use) namespacing.

Additional context

N/A

Closed Issues

N/A
@amkuchta amkuchta mentioned this issue Aug 27, 2019
Closed
@amkuchta
Copy link
Contributor Author

@punker76 if you agree with this, I can create a PR to clean it up.

@punker76
Copy link
Member

/cc @Evangelink WDYT?

@Evangelink
Copy link
Contributor

Yeah :D
I was having the same feeling when working on adding MUI styles.

@amkuchta
Copy link
Contributor Author

Should I go ahead and create a PR, @punker76 & @Evangelink? And if so, would you like me to break out the namespace a bit more to make room for MUI, perhaps like so:

  • MahApps.Font.Family.Header.Default
  • MahApps.Font.Family.Header.MUI

@Evangelink
Copy link
Contributor

That's ok on my side @amkuchta! Regarding the .Default suffix, it's up to you, I was a bit out of time lately to make progress on MUI.

@amkuchta
Copy link
Contributor Author

I just think it would be nice to have all of the names go to the same depth, and Default tells users what the normal value would be for MA.M vs MA.M's implementation of MUI (or any other style that may be included in the future)

amkuchta added a commit to amkuchta/MahApps.Metro that referenced this issue Oct 14, 2019
@amkuchta
Updates MA.M font namespaces to be more uniform
fc37122 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584
@amkuchta amkuchta mentioned this issue Oct 14, 2019
Merged
punker76 pushed a commit to amkuchta/MahApps.Metro that referenced this issue Oct 14, 2019
@amkuchta @punker76
Updates MA.M font namespaces to be more uniform
59adec0 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584
punker76 pushed a commit to amkuchta/MahApps.Metro that referenced this issue Oct 15, 2019
@amkuchta @punker76
Updates MA.M font namespaces to be more uniform
46e700f 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584
punker76 pushed a commit to amkuchta/MahApps.Metro that referenced this issue Oct 23, 2019
@amkuchta @punker76
Updates MA.M font namespaces to be more uniform
f3f0d0b 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584
punker76 pushed a commit to amkuchta/MahApps.Metro that referenced this issue Oct 29, 2019
@amkuchta @punker76
Updates MA.M font namespaces to be more uniform
e7ad60d 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584
punker76 pushed a commit to amkuchta/MahApps.Metro that referenced this issue Oct 29, 2019
@amkuchta @punker76
Updates MA.M font namespaces to be more uniform
a1de3cf 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584
punker76 pushed a commit to amkuchta/MahApps.Metro that referenced this issue Nov 2, 2019
@amkuchta @punker76
Updates MA.M font namespaces to be more uniform
d316bda 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584
punker76 added a commit to amkuchta/MahApps.Metro that referenced this issue Nov 4, 2019
@punker76
Updates MA.M font namespaces to be more uniform
cc0e00b 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584

XamlStyler
punker76 added a commit to amkuchta/MahApps.Metro that referenced this issue Nov 8, 2019
@punker76
Updates MA.M font namespaces to be more uniform
59df5eb 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584

XamlStyler
punker76 added a commit to amkuchta/MahApps.Metro that referenced this issue Nov 10, 2019
@punker76
Updates MA.M font namespaces to be more uniform
491b58a 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584

XamlStyler
punker76 added a commit to amkuchta/MahApps.Metro that referenced this issue Nov 16, 2019
@punker76
Updates MA.M font namespaces to be more uniform
e199118 
- MA.M font namespacing was inconsistent between sizes and families
- This commit places "MahApps.Fonts" first, followed by "Size" or "Family"
- Further granularity is applied for specificity (e.g. "Content", "Header")
- Items previously named "Default" are now "Base"
- "Default" is added to the end of all items except Win10 ToggleSwitches to allow for future styles
- Items such as "DialogTitle" and "FlyoutHeader" are separated (e.g. "Dialog.Title", "Flyout.Header")

- Resolves MahApps#3584

XamlStyler
@punker76 punker76 added this to the 2.0.0 milestone Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking Change
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Updates MA.M font namespaces to be more uniform amkuchta/MahApps.Metro
3 participants
@punker76 @amkuchta @Evangelink