-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clear the webpack warning #15
Conversation
some test fail, close first, sorry. |
It's ok now. Please review the code. Thank you. @MadMG |
Would be really helpful if this gets merged. |
I'm sorry - I completely lost focus of this PR... for me this looks good to merge 👍 what about you @MadMG ? |
@herom Thanks a lot for merging! Would it be possible to get this released in the near future? |
ah, yes - sorry! I thought that @MadMG would release it, but I'll take a look at it and have it released soon (hopefully today) 👍 |
No worries – thanks a lot for your help! |
@herom Sorry to bother you again, but is it possible that the package isn't released to npm yet? The moment-jdateformatparser page there says that version 1.0.2 is the latest release and I'm also not able to install the new 1.1.0 version in a project. Maybe running Thanks for your help! |
@amannn ya, that's because I wasn't within the list of "collaborators" in npm and I couldn't publish it. I talked to @MadMG the other day and I'm now officially a "collaborator" 😸 so I'm able to release it once I'm at home as we're using a private npm-registry here at work. sorry for the delay, but at the end of the day it should be released and published 💯 |
@herom Ahh, I see 🙂. Thank you so much! Just discovered you're also from Austria. Best wishes from Dornbirn, Vorarlberg 😉 |
You're welcome 👍 Oh, danke - beste Gruesse aus der Steiermark retour 😉 |
@amannn new version released 🥇 |
Hi,
I use moment-jdateformatparse with webpack but have some warning like #11 , and I use vovateleport's answer can clear the warning. So I pull the request to you, please review.
Thank.