Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear the webpack warning #15

Merged
merged 2 commits into from
Jul 21, 2017
Merged

clear the webpack warning #15

merged 2 commits into from
Jul 21, 2017

Conversation

zhaozhiming
Copy link
Contributor

Hi,
I use moment-jdateformatparse with webpack but have some warning like #11 , and I use vovateleport's answer can clear the warning. So I pull the request to you, please review.

Thank.

@zhaozhiming
Copy link
Contributor Author

some test fail, close first, sorry.

@zhaozhiming zhaozhiming reopened this Mar 15, 2016
@zhaozhiming
Copy link
Contributor Author

It's ok now. Please review the code. Thank you. @MadMG

@amannn
Copy link

amannn commented Dec 13, 2016

Would be really helpful if this gets merged.

@amannn
Copy link

amannn commented Jul 20, 2017

@MadMG @herom Is it ok to merge this?

@herom
Copy link
Collaborator

herom commented Jul 20, 2017

I'm sorry - I completely lost focus of this PR... for me this looks good to merge 👍

what about you @MadMG ?

@herom herom merged commit 458fbf0 into MadMG:master Jul 21, 2017
@amannn
Copy link

amannn commented Jul 31, 2017

@herom Thanks a lot for merging! Would it be possible to get this released in the near future?

@herom
Copy link
Collaborator

herom commented Jul 31, 2017

ah, yes - sorry! I thought that @MadMG would release it, but I'll take a look at it and have it released soon (hopefully today) 👍

@amannn
Copy link

amannn commented Jul 31, 2017

No worries – thanks a lot for your help!

@amannn
Copy link

amannn commented Aug 2, 2017

@herom Sorry to bother you again, but is it possible that the package isn't released to npm yet? The moment-jdateformatparser page there says that version 1.0.2 is the latest release and I'm also not able to install the new 1.1.0 version in a project. Maybe running npm publish in the repository is necessary?

Thanks for your help!

@herom
Copy link
Collaborator

herom commented Aug 2, 2017

@amannn ya, that's because I wasn't within the list of "collaborators" in npm and I couldn't publish it. I talked to @MadMG the other day and I'm now officially a "collaborator" 😸 so I'm able to release it once I'm at home as we're using a private npm-registry here at work.

sorry for the delay, but at the end of the day it should be released and published 💯

@amannn
Copy link

amannn commented Aug 2, 2017

@herom Ahh, I see 🙂. Thank you so much!

Just discovered you're also from Austria. Best wishes from Dornbirn, Vorarlberg 😉

@herom
Copy link
Collaborator

herom commented Aug 2, 2017

You're welcome 👍

Oh, danke - beste Gruesse aus der Steiermark retour 😉

@herom
Copy link
Collaborator

herom commented Aug 2, 2017

@amannn new version released 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants