Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix day-of-week format mapping #14

Merged
merged 1 commit into from
Feb 4, 2016
Merged

fix day-of-week format mapping #14

merged 1 commit into from
Feb 4, 2016

Conversation

gboros
Copy link
Contributor

@gboros gboros commented Feb 4, 2016

better day-of-week format mapping

@MadMG
Copy link
Owner

MadMG commented Feb 4, 2016

Why would this be better? The oracle java documentation says:

For formatting, if the number of pattern letters is 4 or more, the full form is used; otherwise a short or abbreviated form is used if available. For parsing, both forms are accepted, independent of the number of pattern letters.

If more than four Es are present, a dynamic mapping would make more sense.

@gboros
Copy link
Contributor Author

gboros commented Feb 4, 2016

it is better because now it works also for 'EE' (this was a bug), and also for more then four (but only 5 and 6) - here of course a dynamic mapping would make it complete, not just better

@MadMG
Copy link
Owner

MadMG commented Feb 4, 2016

I see, you're right! Thx for the fix for EE.

Maybe I have time to add a dynamic mapping in the future.

@MadMG MadMG closed this Feb 4, 2016
@MadMG MadMG reopened this Feb 4, 2016
MadMG added a commit that referenced this pull request Feb 4, 2016
fix day-of-week format mapping
@MadMG MadMG merged commit d01ba38 into MadMG:master Feb 4, 2016
@herom
Copy link
Collaborator

herom commented Feb 4, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants