Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsafe float == in logodds LUT; add unit tests #983

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

jlblancoc
Copy link
Member

Finally fixes the 1st bug reported in #949, which was still present in PPA 32bit builds.

Closes #949

@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #983 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #983      +/-   ##
===========================================
+ Coverage     37.1%   37.11%   +<.01%     
===========================================
  Files         1190     1191       +1     
  Lines       104657   104673      +16     
===========================================
+ Hits         38834    38847      +13     
- Misses       65823    65826       +3
Impacted Files Coverage Δ
libs/ros1bridge/include/mrpt/ros1bridge/map.h 100% <ø> (ø) ⬆️
libs/maps/include/mrpt/maps/CLogOddsGridMapLUT.h 88.46% <100%> (-1.54%) ⬇️
libs/maps/src/maps/CLogOddsGridMapLUT_unittest.cpp 100% <100%> (ø)
libs/slam/src/slam/se3_ransac_unittest.cpp 95.83% <0%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93706b9...e584fed. Read the comment docs.

@jlblancoc jlblancoc merged commit cb07f55 into develop Nov 4, 2019
@jlblancoc jlblancoc deleted the fix/gridmap-lut-i386-bug branch November 4, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Debian issues after merging ROS 1 stuff
1 participant