Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not use Toolbar commands from none-file-windows like the project properties window #16

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

ccHanibal
Copy link
Contributor

As the title says there was an error when triggering any command when the project properties window was active. This is beacuse solution.DTE.ActiveDocument throws an exception in this case rather than returning null.

I could not really test this because I can no longer open the solution with VS 2015. Setting the MinimumVisualStudioVersion to 14.0 lets me open the solution but I get build errors of which I read that I need to install VS 2017 to resolve them which I do not have.

@MattDavies
Copy link
Member

Hi @ccHanibal, thanks for the PR.

I've just tried some commands while the Properties window is active, and I don't see the same behaviour. Might possibly be a 2015 thing as I'm running 2017.

What's the exact exception? Would be good to replicate so I can verify this works.

@ccHanibal
Copy link
Contributor Author

It's an ArgumentException. Text from message box is:

Invalid parameter. (Exception with HRESULT: 0x80070057 (E_INVALIDARG))

grafik

@ccHanibal
Copy link
Contributor Author

ccHanibal commented May 25, 2017

In the MSDN it even states this although it talks about VS 2005.

The active document property throws an exception when the project Properties window is opened in Microsoft Visual Studio 2005.

@ccHanibal
Copy link
Contributor Author

@MattDavies Any chance you will merge this?

@MattDavies
Copy link
Member

Hey @ccHanibal, so sorry to take so long to get to this. I was just able to replicate this on 2017 as well. Thanks for the PR!

@MattDavies MattDavies merged commit 71dfa78 into MRCollective:master Jun 15, 2017
@MattDavies
Copy link
Member

Published as 1.0.2, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants