Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix dft energy printouts #483

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

gitpeterwind
Copy link
Member

DFT energy was not summed cleanly in the omp loop.

Copy link
Contributor

@stigrj stigrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@stigrj
Copy link
Contributor

stigrj commented Apr 30, 2024

Not sure what to do with the failing macos build, though

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.66%. Comparing base (1e7ea8e) to head (df39ee2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files         194      194           
  Lines       15285    15287    +2     
=======================================
+ Hits        10495    10497    +2     
  Misses       4790     4790           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stigrj
Copy link
Contributor

stigrj commented May 1, 2024

Includes temporary fix for failing macos-latest pipeline, see conda-incubator/setup-miniconda#344

@stigrj stigrj merged commit d5805a3 into MRChemSoft:master May 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants