MAINT: encore Windows type fixes #4369
Conversation
* in NumPy `2.0.0`, the default integer size on Windows will be 64-bit; we have 10 related test failures on Windows alongside NumPy `main` at the moment, and this patch fixes those failures by forcing a reversion to the old behavior, effectively kicking the can down the road * I think we're going to proceed with a similar solution upstream for now (i.e., scipy/scipy#19605 (comment)); [skip cirrus]
Linter Bot Results:Hi @tylerjereddy! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
|
With encore moving to MDAEncore, I'm not sure if this fix should go here or there or both :/ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4369 +/- ##
==========================================
Coverage 93.37% 93.37%
==========================================
Files 170 184 +14
Lines 22340 23453 +1113
Branches 4085 4085
==========================================
+ Hits 20859 21899 +1040
- Misses 963 1036 +73
Partials 518 518 ☔ View full report in Codecov by Sentry. |
|
Ok, let me know what you want me to do. You have a PR to improve optional dep resolution right? Does that need to go in soon/first? |
There was a problem hiding this comment.
Given it's a single line fix, I'm tempted to say let's merge this and we can port it over (if that's ok with you @tylerjereddy) - does this sound reasonable with you @orbeckst ?
|
We do need to deprecate Encore properly, I'll raise an issue in the morning. |
in NumPy
2.0.0, the default integer size on Windows will be 64-bit; we have 10 related test failures on Windows alongside NumPymainat the moment, and this patch fixes those failures by forcing a reversion to the old behavior, effectively kicking the can down the roadI think we're going to proceed with a similar solution upstream for now (i.e., BUG: wheel runs have a *lot* of test fails at the moment. scipy/scipy#19605 (comment));
I haven't kept up with whether this should actually be targeted at the encore "subproject" now with the reorg happening; feel free to move it if so...
[skip cirrus]
📚 Documentation preview 📚: https://mdanalysis--4369.org.readthedocs.build/en/4369/