Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: CHANGELOG MM/DD/YY #4368

Merged

Conversation

tylerjereddy
Copy link
Member

@tylerjereddy tylerjereddy commented Dec 15, 2023

  • I merged [WIP] Fix authors & changelog #4361 a bit early, so I should clean up the mess; I think this fixes the two cases where the datetime string was not formatted to match our documented convention

[skip cirrus]


📚 Documentation preview 📚: https://mdanalysis--4368.org.readthedocs.build/en/4368/

* I merged MDAnalysisgh-4361 a bit early, so I should clean up the mess;
I think this fixes the two cases where the datetime string was
not formatted to match our documented convention

[skip cirrus]
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (also I would say it's mostly my fault for messing up in the first place 😅)

Copy link

Linter Bot Results:

Hi @tylerjereddy! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d6a8ce) 93.37% compared to head (23a5b04) 93.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #4368     +/-   ##
==========================================
  Coverage    93.37%   93.37%             
==========================================
  Files          170      184     +14     
  Lines        22340    23453   +1113     
  Branches      4085     4085             
==========================================
+ Hits         20859    21899   +1040     
- Misses         963     1036     +73     
  Partials       518      518             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoStoe JoStoe mentioned this pull request Dec 16, 2023
5 tasks
@IAlibay IAlibay merged commit 75d240e into MDAnalysis:develop Dec 16, 2023
22 of 25 checks passed
@tylerjereddy tylerjereddy deleted the treddy_changelog_mdy_format branch December 16, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants