Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add post deployment conda and pypi cron tests #4210

Merged
merged 8 commits into from
Jul 26, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 25, 2023

Fixes #4208

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

📚 Documentation preview 📚: https://mdanalysis--4210.org.readthedocs.build/en/4210/

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a1aff66) 93.62% compared to head (b3066bc) 93.62%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4210   +/-   ##
========================================
  Coverage    93.62%   93.62%           
========================================
  Files          193      193           
  Lines        25295    25295           
  Branches      4063     4063           
========================================
  Hits         23683    23683           
  Misses        1096     1096           
  Partials       516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay IAlibay changed the title [wip] Add post deployment conda and pypi cron tests [CI] Add post deployment conda and pypi cron tests Jul 26, 2023
@IAlibay
Copy link
Member Author

IAlibay commented Jul 26, 2023

Ok current CI test failuires are down to known issues so I won't fix them here:

@MDAnalysis/coredevs if I can get a review / merge here we can move forward towards fixing #4211

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as far as I can tell. I don’t know how you’ve tested that the cron job ran but I trust your report.

Thank you for adding these tests!

.github/workflows/gh-ci-cron.yaml Show resolved Hide resolved
.github/workflows/gh-ci-cron.yaml Show resolved Hide resolved
@IAlibay
Copy link
Member Author

IAlibay commented Jul 26, 2023

Thanks! Cron jobs were just enabled to run on this PR until ~ 2 commits ago.

@orbeckst
Copy link
Member

Please merge at your leisure.

@IAlibay IAlibay merged commit d161858 into develop Jul 26, 2023
23 checks passed
@IAlibay IAlibay deleted the canary-in-a-coalmine branch July 26, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] conda & pypi post deployment tests
2 participants