Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip stderr checks in nbval #358

Merged
merged 11 commits into from
Jan 15, 2024
Merged

Skip stderr checks in nbval #358

merged 11 commits into from
Jan 15, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 2, 2024

@pep8speaks
Copy link

pep8speaks commented Jan 2, 2024

Hello @IAlibay! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-01-13 01:52:29 UTC

@IAlibay
Copy link
Member Author

IAlibay commented Jan 2, 2024

This didn't work - closing as I wouldn't have the time to dig into this.

@IAlibay IAlibay closed this Jan 2, 2024
@IAlibay IAlibay reopened this Jan 13, 2024
@IAlibay IAlibay changed the title [WIP] Skip stderr checks in nbval Skip stderr checks in nbval Jan 13, 2024
@IAlibay
Copy link
Member Author

IAlibay commented Jan 13, 2024

This should be good to go.

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, amazing, thank you @IAlibay -- LGTM!

@lilyminium lilyminium merged commit d8b12ab into develop Jan 15, 2024
4 checks passed
@IAlibay IAlibay deleted the stderr-skip branch January 20, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbval errors on stderr output changes
3 participants