Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dutch translation #168

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Update Dutch translation #168

merged 2 commits into from
Jan 30, 2024

Conversation

mboeren
Copy link
Contributor

@mboeren mboeren commented Jan 30, 2024

No description provided.

mboeren and others added 2 commits January 29, 2024 18:59
Signed-off-by: MichelB <109305769+mboeren@users.noreply.github.com>
@Luzifer
Copy link
Owner

Luzifer commented Jan 30, 2024

Thank you very much for updating the translations! 🙂

@Luzifer Luzifer merged commit 564cbe5 into Luzifer:master Jan 30, 2024
3 checks passed
@sorcix
Copy link
Contributor

sorcix commented Feb 10, 2024

I think this is worse than before.

"Geheim" is the literal translation of "secret" but I wouldn't use it in a context like this. I would use it in sentences like "let me tell you a secret" when you're going to tell someone a story. At least when used as a noun, it should be used as an adjective in an app like this. I've rolled this back in my production deploy as it makes ots look like a fairy tale to our customers.

The "vertrouwelijke info" as I translated it before is also not ideal, though.

On ontimesecret.com they're using "geheime informatie" (as an adjective), which is a mix between the two. They also use "gevoelige informatie." I think both these options are more correct than "geheim."

@mboeren

@Luzifer
Copy link
Owner

Luzifer commented Feb 10, 2024

Hmm sadly my Dutch isn't good enough to really contribute to the translation: I do understand a lot but cannot speak (or write)… So do you have a proposal how to proceed and maybe prevent this in the future?

The only thing I can do is to rely on native-speakers to translate (and from my side to do some checks whether there is something in there which is "totally off-topic")…

So

  1. what do we do with this translation? If you state that's not professional we maybe should roll-back too? Do you want to try to agree on a "better" translation (as you mentioned in the last paragraph)?
  2. how can we make sure we do have the best possible translation in the future? Is there any solution already out there, I'm not aware of, to fix this?

@mboeren
Copy link
Contributor Author

mboeren commented Feb 10, 2024

I disagree, because when using using OTS, you're always creating a 'secret', you're not creating 'secret information'. And while in some cases, it looks a bit odd using 'geheim/secret', it at least provides consistency and it is clear we're always talking about the same object.

I agree that 'geheim' is not the prettiest word in Dutch, but for lack of a better alternative, it is the best translation in the context in my opinion.

I think the problem here is that the word 'secret' is something we've been used to seeing in an IT context and therefore we're more accepting of using it this way, even though it has the same problems as you've described with 'geheim'. This is what you get when translating things like these.

@sorcix
Copy link
Contributor

sorcix commented Feb 10, 2024

Languages are hard. There's also a difference between the dutch/flemish as spoken in Belgium and the Netherlands.

Regarding "lack of a better alternative," What do you think about the alternatives I suggested? I couldn't find any other service using "geheim." (Granted, most similar services don't offer dutch translations.)

Anyway, I'm already maintaining a fork for branding. Adding a patch for this weird translation is doable for me.

@sorcix
Copy link
Contributor

sorcix commented Feb 10, 2024

As another datapoint: Bitwarden Send (a similar secret sharing service) just uses the word "Send" in dutch sentences ("gebruikers kunnen deze Send niet meer benaderen"). While I think using an english word in a dutch sentence is weird, they also didn't use "geheim."

@sorcix
Copy link
Contributor

sorcix commented Feb 10, 2024

The dutch wikipedia doesn't even translate "secret sharing."

https://nl.m.wikipedia.org/wiki/Secret_sharing

Maybe we should just use "secret" like in the german translation.

@mboeren
Copy link
Contributor Author

mboeren commented Feb 12, 2024

I think your alternatives are good from a language point of view, I'm just apprehensive of mixing terminology. So for example, when you use 'gevoelige informatie/sensitive information', in my mind you're no longer referring to the object you're creating. The information/data you already have, because you're pasting that into the tool. All you're doing in the tool is create the object (the secret). And I think every translated line here refers to this object, not the data it contains.

I'm perfectly okay with changing it to 'secret' and keep using English for this. After all, the tool, regardless of language, is called 'One Time Secrets'. :)

@Luzifer
Copy link
Owner

Luzifer commented Mar 2, 2024

Any news on this for a patch both of you agree on? I'd like to release the latest language changes soon and that would include the change in the Dutch translations.

@Luzifer
Copy link
Owner

Luzifer commented Jun 19, 2024

@sorcix @mboeren do you have any changes you want to have in the next release? Last release was ages ago and the next would include this translation.

@sorcix
Copy link
Contributor

sorcix commented Jun 20, 2024

Sorry for the late response!

Keeping the new translation as-is is fine for me.

I still think the translation makes it sound like a joke, but I'm using a fork at work anyway. Keeping the original translation there is not much work at all. Due to other things in life I don't have the time or mental capacity to help find a solution right now. I think this boils down to a difference in "dutch" between Belgium and The Netherlands, so it's not an easy one to tackle. 😄

@Luzifer
Copy link
Owner

Luzifer commented Aug 16, 2024

@sorcix something just came to my mind when re-visiting this issue: You've said it boils down to a difference of nl-NL and nl-BE

We could re-instate the old translation as nl-BE and use this one as nl-NL… Would that solve the issue? Then people having their browser set to "Dutch (Belgium)" would get the old one, people having "Dutch (Netherlands)" would get this one…

@mboeren @sorcix would you both agree on this being a good way forward?

Luzifer added a commit that referenced this pull request Aug 27, 2024
As result of the discussion in #168 this restores the "old" Dutch
translation as `nl-BE` as it seems there are major differences between
the Dutch spoken in NL and the one in BE. This way the differences in
the language are used for the different countries.

The `nl-NL` translation is used as "standard NL" as there are plenty
more `nl-*` language keys. Those are served by the translation for the
Netherlands.

Signed-off-by: Knut Ahlers <knut@ahlers.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants