Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the wxPython dependency #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kurtmckee
Copy link
Contributor

This PR introduces the following changes:

  • Remove the wxPython code, examples, and Gui package extra

git blame shows that the smartcard.wx module was introduced 17 years ago, in 2007, and that the code itself has been largely untouched except to resolve linter warnings and update copyright years [example].

Therefore I'm suggesting to discard the wxPython code because it appears to be unmaintained code.

@coveralls
Copy link

coveralls commented Oct 3, 2024

Coverage Status

coverage: 68.019% (+6.2%) from 61.833%
when pulling 44726ea on kurtmckee:rm-wx
into d276747 on LudovicRousseau:master.

@LudovicRousseau
Copy link
Owner

My problem is that I do not know if smartcard.wx is used or not by PySCard users.

Since the code is broken since some years I guess the answer is: no.

@LudovicRousseau LudovicRousseau self-assigned this Oct 3, 2024
@kurtmckee
Copy link
Contributor Author

kurtmckee commented Oct 3, 2024

I wasn't able to install wxPython on Linux after about two hours of effort, so I'm only stating that the smartcard.wx code doesn't appear to have been meaningfully updated in 17 years, and I'm recommending removing unmaintained code.

@LudovicRousseau
Copy link
Owner

sudo apt install python3-wxgtk4.0

@kurtmckee
Copy link
Contributor Author

Nice! Thanks for suggesting that!

I'm going to be out for a while, so if you've installed wxPython and confirmed that smartcard.wx cannot be imported or run, then feel free to merge, otherwise I'll try testing installing from apt when I'm able to. 👍

@kurtmckee
Copy link
Contributor Author

I ended up having an opportunity to install and try running the app in SimpleSCardApp.py and found that a window opened but didn't render anything. Eventually I received a KDE pop-up stating that the window wasn't responding and asking if I wanted to kill the process.

Based on the age of the smartcard.wx code and the experience described above, I recommend merging this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants