add Gitment comment support #456

deamwork · 2017-11-01T15:36:19Z

Configuration

Operating system with version : macOS Sirrea 10.12.6 (Darwin 16.7.0 darwin x64)
Node version : v7.8.0
Hexo version : v3.2 (Maybe? Not sure how to check it.)
Hexo-cli version : v1.0.3

Changes proposed

add Gitment comment support.
tweak date display on the archive page.

deamwork · 2017-11-01T15:44:34Z

Well, this is my first PR on this repo.

Not sure how you think about that tweak on the archive page, but showing all lowercase letter seems to be pretty odd to me.

So if you feel uncomfortable with this tweak, just ignore that commit (67e7f49).

LouisBarranqueiro

👋 @deamwork, thanks for this cool feature! 😄

Can you write a quick guide to enable me to test it and make sure it works with the theme please?

LouisBarranqueiro · 2017-11-23T08:22:14Z

_config.yml

@@ -174,6 +174,22 @@ archive_pagination: true
 category_pagination: true
 tag_pagination: true

+# Gitment - A github issue comment tool.


uncomment these lines

LouisBarranqueiro · 2017-11-23T08:24:45Z

layout/_partial/post/gitment.ejs

@@ -0,0 +1 @@
+<div id="gcomment"></div>


I think gitment or gitment-comments would be more appropriate

Changed as requested. :)

LouisBarranqueiro · 2017-11-23T08:24:49Z

layout/_partial/post/actions.ejs

+                <a class="post-action-btn btn btn--default" href="#gcomment">
+                     <i class="fa fa-comment-o"></i>
+                </a>
+              <% } else { %>


you need to check else if (theme.disqus_shortname || theme.duoshuo_shortname) otherwise it will display empty elements.

Another careless action... omg...

LouisBarranqueiro · 2017-11-23T08:25:50Z

layout/_partial/archive-post.ejs

@@ -34,7 +34,7 @@
            <% } %>
            <li class="archive-post archive-day" data-date="<%= post.date.format('YYYYMMDD') %>">
                <a class="archive-post-title" href="<%- url_for(post.path) %>"><%= post.title || '(' + __('post.no_title') + ')' %></a>
-                <span class="archive-post-date"><%= ' - ' + post.date.locale(page.lang).format(__('date_format')).toLowerCase() %></span>
+                <span class="archive-post-date"><%= ' - ' + post.date.locale(page.lang).format(__('date_format')) %></span>


revert this and let's focus on the gitment feature :)

That's okay, reverted.

LouisBarranqueiro · 2017-11-23T08:25:55Z

_config.yml

+#   # Switch
+#   enable: false
+#   # Your Github ID here (Github username):
+#   githubID:


use snake case in yaml file

Sorry about that, I didn't even notice about that. 👍
My habit prefers CamelCase.

deamwork · 2017-11-23T13:33:42Z

Pushed (83534bf), little tweaks for this merge

deamwork · 2017-11-23T13:43:03Z

Document:

Go to Github applications page.
Create a new application.
Put your blog home URL for Homepage URL & Authorization callback URL (Important).
Confirm to register that application.
Get Client ID & Client Secret of this application.
Edit your _config.yml file, put those data into this theme config file.
Enable Gitment by set enable: false to enable: true.

You have to fill in your callback URL because your Client Secret is hard-coded in Gitment configuration.
For more security details, please read it here: https://github.com/imsun/gitment#about-security

LouisBarranqueiro

Could you please add Gitment in Integrated services in the user documentation? 😄

LouisBarranqueiro · 2017-11-25T08:44:04Z

layout/_partial/script.ejs

@@ -36,6 +36,33 @@
                || document.getElementsByTagName('body')[0]).appendChild(ds);
            })();
        </script>
+    <% } else if (theme.gitment.enable) { %>
+        <script type="text/javascript">
+            (function() {


I updated a bit the script to init Gitment when the gitment script is loaded because if network is slow, it will throw an error ReferenceError: Can't find variable: Gitment

(function() { function render() { new Gitment({ id: '<%= post.permalink %>', owner: '<%- theme.gitment.github_id %>', repo: '<%- theme.gitment.repo %>', oauth: { client_id: '<%- theme.gitment.client_id %>', client_secret: '<%- theme.gitment.client_secret %>', } }).render('gitment'); } var gc = document.createElement('script'); gc.type = 'text/javascript'; gc.src = 'http://imsun.github.io/gitment/dist/gitment.browser.js'; gc.charset = 'UTF-8'; gc.onload = render; gc.async = true; document.querySelector('body').appendChild(gc); var gcs = document.createElement('link'); gcs.href = '//imsun.github.io/gitment/style/default.css'; gcs.type = 'text/css'; gcs.rel = 'stylesheet'; gcs.media = 'screen,print'; document.querySelector('head').appendChild(gcs); })();

Thanks for the doc, it works well. Very simple and powerful comment system! 😎

LouisBarranqueiro · 2017-11-25T08:48:23Z

_config.yml

+# Repository: https://github.com/imsun/gitment
+# Demo: https://imsun.github.io/gitment/
+# Introduction: https://imsun.net/posts/gitment-introduction/
+# Quick link to setup a new Github application: https://github.com/settings/applications/new


Now that we have multiple comment systems, let's create a section for them before Integrated services. It will be well organized.

# Comments # You can only use one of this service # Your Disqus shortname disqus_shortname: # Your Duoshuo shortname duoshuo_shortname: # Your Gitment information # Read https://github.com/imsun/gitment#get-started to setup Gitment gitment: ... ``

LouisBarranqueiro · 2017-11-25T09:03:08Z

_config.yml

@@ -174,6 +174,22 @@ archive_pagination: true
 category_pagination: true
 tag_pagination: true

+# Gitment - A github issue comment tool.
+# Repository: https://github.com/imsun/gitment


Just put Read https://github.com/imsun/gitment#get-started to setup Gitment.

It will be easier to maintain (less links)

deamwork · 2017-11-25T12:17:14Z

Changed as your request. 🎉

LouisBarranqueiro · 2017-11-25T20:00:07Z

LGTM. Thanks buddy 😄

* add Gitment comment support. * tweak date display in archive page. * fix code indentation issue, update config. * Tweaks for merge. * update load script & config file change.

deamwork · 2018-06-12T03:32:30Z

BTW, which commit management tool you are using?
I can see that you pushed my pr as your commit but not changing the author.
I was wondering how did you do that...
In this commit: 557ec3f.

LouisBarranqueiro · 2018-06-12T04:16:06Z

I just used the squash and merge feature of GitHub

deamwork · 2018-06-12T04:20:59Z

Okay, I got it. I thought it was a feature of some commit management software.
Thanks! 😄

deamwork added 3 commits November 1, 2017 23:19

add Gitment comment support.

45eb1db

tweak date display in archive page.

67e7f49

fix code indentation issue, update config.

c3b1e03

LouisBarranqueiro requested changes Nov 23, 2017

View reviewed changes

Tweaks for merge.

83534bf

deamwork changed the title ~~add Gitment comment support & little tweak about date display~~ add Gitment comment support Nov 23, 2017

LouisBarranqueiro requested changes Nov 25, 2017

View reviewed changes

update load script & config file change.

165fea9

LouisBarranqueiro added the type: feature label Nov 25, 2017

LouisBarranqueiro approved these changes Nov 25, 2017

View reviewed changes

LouisBarranqueiro merged commit 294966b into LouisBarranqueiro:master Nov 25, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Gitment comment support #456

add Gitment comment support #456

deamwork commented Nov 1, 2017

deamwork commented Nov 1, 2017

LouisBarranqueiro left a comment

LouisBarranqueiro Nov 23, 2017

LouisBarranqueiro Nov 23, 2017

deamwork Nov 23, 2017

LouisBarranqueiro Nov 23, 2017

deamwork Nov 23, 2017

LouisBarranqueiro Nov 23, 2017

deamwork Nov 23, 2017

LouisBarranqueiro Nov 23, 2017

deamwork Nov 23, 2017

deamwork commented Nov 23, 2017

deamwork commented Nov 23, 2017 •

edited

Loading

LouisBarranqueiro left a comment

LouisBarranqueiro Nov 25, 2017

LouisBarranqueiro Nov 25, 2017

LouisBarranqueiro Nov 25, 2017

LouisBarranqueiro Nov 25, 2017

deamwork commented Nov 25, 2017 •

edited

Loading

LouisBarranqueiro commented Nov 25, 2017

deamwork commented Jun 12, 2018 •

edited

Loading

LouisBarranqueiro commented Jun 12, 2018

deamwork commented Jun 12, 2018

add Gitment comment support #456

add Gitment comment support #456

Conversation

deamwork commented Nov 1, 2017

Configuration

Changes proposed

deamwork commented Nov 1, 2017

LouisBarranqueiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deamwork commented Nov 23, 2017

deamwork commented Nov 23, 2017 • edited Loading

LouisBarranqueiro left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deamwork commented Nov 25, 2017 • edited Loading

LouisBarranqueiro commented Nov 25, 2017

deamwork commented Jun 12, 2018 • edited Loading

LouisBarranqueiro commented Jun 12, 2018

deamwork commented Jun 12, 2018

deamwork commented Nov 23, 2017 •

edited

Loading

deamwork commented Nov 25, 2017 •

edited

Loading

deamwork commented Jun 12, 2018 •

edited

Loading