Create method for building error messages

Lombiq · May 10, 2024 · e3da0f6 · e3da0f6
1 parent fb4483e
commit e3da0f6
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/Lombiq.Tests.UI/Docs/Configuration.md b/Lombiq.Tests.UI/Docs/Configuration.md
@@ -67,7 +67,7 @@ configuration => configuration.HtmlValidationConfiguration.AssertHtmlValidationR
     {
         var errors = validationResult.GetParsedErrors()
             .Where(error => error.RuleId is not "prefer-native-element");
-        errors.ShouldBeEmpty(string.Join('\n', errors.Select(error => error.Message)));
+        errors.ShouldBeEmpty(HtmlValidationResultExtensions.GetParsedErrorMessageString(errors));
         return Task.CompletedTask;
     });
 ```

diff --git a/Lombiq.Tests.UI/Extensions/HtmlValidationResultExtensions.cs b/Lombiq.Tests.UI/Extensions/HtmlValidationResultExtensions.cs
@@ -2,6 +2,7 @@
 using Lombiq.Tests.UI.Models;
 using System;
 using System.Collections.Generic;
+using System.Globalization;
 using System.IO;
 using System.Linq;
 using System.Text.Json;
@@ -31,6 +32,13 @@ public static async Task<IEnumerable<string>> GetErrorsAsync(this HtmlValidation
     /// </summary>
     public static IEnumerable<JsonHtmlValidationError> GetParsedErrors(this HtmlValidationResult result) => ParseOutput(result.Output);
 
+    public static string GetParsedErrorMessageString(IEnumerable<JsonHtmlValidationError> errors) =>
+        string.Join(
+            '\n', errors.Select(error =>
+                $"{error.Line.ToString(CultureInfo.InvariantCulture)}:{error.Column.ToString(CultureInfo.InvariantCulture)} - " +
+                $"{error.Message} - " +
+                $"{error.RuleId}"));
+
     private static IEnumerable<JsonHtmlValidationError> ParseOutput(string output)
     {
         try

diff --git a/Lombiq.Tests.UI/Services/HtmlValidationConfiguration.cs b/Lombiq.Tests.UI/Services/HtmlValidationConfiguration.cs
@@ -5,7 +5,6 @@
 using Shouldly;
 using System;
 using System.IO;
-using System.Linq;
 using System.Threading.Tasks;
 
 namespace Lombiq.Tests.UI.Services;
@@ -97,7 +96,7 @@ public HtmlValidationConfiguration WithRelativeConfigPath(params string[] pathSe
                 validationResult.Output.Trim().StartsWith('{'))
             {
                 var errors = validationResult.GetParsedErrors();
-                errors.ShouldBeEmpty(string.Join('\n', errors.Select(error => error.Message)));
+                errors.ShouldBeEmpty(HtmlValidationResultExtensions.GetParsedErrorMessageString(errors));
             }
             else
             {