Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix healthcheck issue on Docker #72

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

sameersubudhi
Copy link
Member

@sameersubudhi sameersubudhi commented Sep 25, 2024

What was the problem?

This PR resolves #LISK-1129

How was it solved?

  • Update healthcheck command on the Docker container
  • Set the API server host/port within the containers via the env file build script
  • Update default API server host to be 0.0.0.0
  • Update docker dev script to build image from local

How was it tested?

Start the containers locally with the docker dev scripts
Run: curl --fail http://localhost:3000/healthz and check container health with docker ps

Copy link

@matjazv matjazv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and health check works as expected!

@sameersubudhi sameersubudhi merged commit 4235e14 into master Sep 25, 2024
1 check passed
@sameersubudhi sameersubudhi deleted the LISK-1129-Healthcheck-is-failing-on-Docker branch September 25, 2024 14:01
Incede added a commit that referenced this pull request Sep 26, 2024
Incede added a commit that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants