Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/sixty forty reward split #916

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Conversation

vlady-kotsev
Copy link
Collaborator

Detailed description:

  • Add reward split functionality based on validators/treasury ratio
  • Update unit tests

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 50.76923% with 32 lines in your changes missing coverage. Please review.

Project coverage is 64.44%. Comparing base (b96b334) to head (cd86074).
Report is 6 commits behind head on main.

Current head cd86074 differs from pull request most recent head d9e3e8e

Please upload reports for the commit d9e3e8e to get more accurate results.

Files Patch % Lines
app/services/fee/distributor/distributor.go 50.00% 17 Missing ⚠️
.../process/handler/read-only/fee-transfer/handler.go 0.00% 7 Missing ⚠️
app/process/handler/read-only/fee/handler.go 42.85% 3 Missing and 1 partial ⚠️
app/process/handler/read-only/nft/fee/handler.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   64.29%   64.44%   +0.14%     
==========================================
  Files          86       86              
  Lines        6716     6752      +36     
==========================================
+ Hits         4318     4351      +33     
- Misses       2184     2185       +1     
- Partials      214      216       +2     
Flag Coverage Δ
unittests 64.44% <50.76%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vlady-kotsev vlady-kotsev marked this pull request as ready for review June 28, 2024 06:55
@valeriivanchev valeriivanchev merged commit c1f94d4 into main Jul 1, 2024
2 of 4 checks passed
@valeriivanchev valeriivanchev deleted the feat/sixty-forty-reward-split branch July 1, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants