Better failsafes exist

LezWatch · Dec 15, 2023 · d6e45e6 · d6e45e6
1 parent 09c1363
commit d6e45e6
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/inc/widgets/character-widget.php b/inc/widgets/character-widget.php
@@ -74,8 +74,10 @@ public function widget( $args, $instance ) {
 				echo '<h4 class="card-title">' . esc_html( get_the_title() ) . '</h4>';
 				echo '<div class="card-text">';
 					// Only show one show
+					// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 					echo lwtv_plugin()->get_character_data( get_the_ID(), 'oneshow' );
 					// Actor
+					// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
 					echo lwtv_plugin()->get_character_data( get_the_ID(), 'oneactor' );
 				echo '</div>
 			</div>';

diff --git a/related-post-plugin/related-posts-lwtv-cards.php b/related-post-plugin/related-posts-lwtv-cards.php
@@ -19,14 +19,12 @@
  *                           Empty array if no related posts are found.
  * @var array $rpbt_args     Widget or shortcode arguments.
  */
-?>
 
-<?php
 /**
  * Note: global $post; is used before this template by the widget and the shortcode.
  */
 
-if ( $related_posts ) {
+if ( is_array( $related_posts ) && $related_posts ) {
 	?>
 	<div class="container related-posts-by-taxonomy-container">
 		<div class="row site-loop related-posts-by-taxonomy-loop">

diff --git a/template-parts/content-post_type_actors.php b/template-parts/content-post_type_actors.php
@@ -239,11 +239,10 @@
 	<section name="related-posts" id="related-posts" class="relatedposts-section">
 		<h2>Related Articles</h2>
 		<div class="card-body">
-			<?php
-			if ( method_exists( 'LWTV_CPTs_Related_Posts', 'related_posts' ) && method_exists( 'LWTV_CPTs_Related_Posts', 'count_related_posts' ) ) {
-				echo lwtv_plugin()->get_cpt_related_posts( $slug ); // phpcs:ignore WordPress.Security.EscapeOutput
-			}
-			?>
+		<?php
+		// phpcs:ignore WordPress.Security.EscapeOutput
+		echo lwtv_plugin()->get_cpt_related_posts( $slug );
+		?>
 		</div>
 	</section>
 	<?php
@@ -267,8 +266,10 @@
 			echo wp_kses_post( '<p>There ' . sprintf( _n( 'is <strong>%s</strong> character', 'are <strong>%s</strong> characters', $havecharcount ), $havecharcount ) . ' listed for this actor; ' . $deadtext . '.</p>' );
 
 			echo '<div class="container characters-regulars-container"><div class="row site-loop character-show-loop">';
-			foreach ( $all_chars as $character ) {
-				include locate_template( 'template-parts/excerpt-post_type_characters.php' );
+			if ( is_array( $all_chars ) ) {
+				foreach ( $all_chars as $character ) {
+					include locate_template( 'template-parts/excerpt-post_type_characters.php' );
+				}
 			}
 			echo '</div></div>';
 		}

diff --git a/template-parts/content-post_type_shows.php b/template-parts/content-post_type_shows.php
@@ -128,9 +128,8 @@
 		<h2>Articles</h2>
 		<div class="container"><div class="card-body">
 			<?php
-			if ( method_exists( 'LWTV_CPTs_Related_Posts', 'related_posts' ) && method_exists( 'LWTV_CPTs_Related_Posts', 'count_related_posts' ) ) {
-				echo lwtv_plugin()->get_cpt_related_posts( $slug ); // phpcs:ignore WordPress.Security.EscapeOutput
-			}
+			// phpcs:ignore WordPress.Security.EscapeOutput
+			echo lwtv_plugin()->get_cpt_related_posts( $slug );
 			?>
 		</div></div>
 	</section>