Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a universal binary to support M1 (Apple silicon) #781

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

vweevers
Copy link
Member

@vweevers vweevers commented Aug 29, 2021

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Aug 29, 2021
@vweevers vweevers mentioned this pull request Aug 29, 2021
binding.gyp Outdated Show resolved Hide resolved
@vweevers vweevers marked this pull request as ready for review September 24, 2021 14:37
@vweevers vweevers changed the title Build universal binary for M1 (Apple silicon) Build a universal binary to support M1 (Apple silicon) Sep 24, 2021
Nazgolze added a commit to Nazgolze/rocksdb that referenced this pull request Sep 24, 2021
@vweevers vweevers merged commit 26ea717 into master Sep 28, 2021
@vweevers vweevers deleted the apple-silicon branch September 28, 2021 16:26
an9949an pushed a commit to an9949an/leveldown that referenced this pull request Aug 15, 2023
On mac, the prebuilt binary (as well as the binary built by
`npm i --build-from-source`) is now a universal binary that's
suitable for both x86_64 (as before) and arm64 (new).

Also sets MACOSX_DEPLOYMENT_TARGET, to 10.7 which is the same target
that Node.js 10 uses and thus what we already supported, but now
explicitly.

Ref Level#766

(cherry picked from commit 26ea717)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Bug fixes that are backward compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mac arm64 prebuild
2 participants