Skip to content
This repository has been archived by the owner on Jul 15, 2022. It is now read-only.

LIVE-545 Add feature flag for enabling USB firmware update on LLM #1843

Merged

Conversation

grsoares21
Copy link
Contributor

@grsoares21 grsoares21 commented Mar 31, 2022

Context (issues, jira)

LIVE-545

Description / Usage

This branch creates the definition of a new feature flag to be used for the mobile firmware update feature.
It also puts string as a possible type for feature flags in order to allow us to develop even without upgrading live-common.

Expectations

  • Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

@grsoares21 grsoares21 requested a review from a team as a code owner March 31, 2022 13:51
@vercel
Copy link

vercel bot commented Mar 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/HufAdcrXSPSexUJfnVkTsGiZdo31
✅ Preview: https://ledger-live-common-git-feat-live-545-add-ff-for-1f20e9-ledgerhq.vercel.app

Copy link
Contributor

@thomasrogerlux thomasrogerlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have mixed feelings about the string addition but okay

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

❗ No coverage uploaded for pull request base (release/22.1.x@216c3e5). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 644f2b1 differs from pull request most recent head b2f469b. Consider uploading reports for the commit b2f469b to get more accurate results

@@                Coverage Diff                @@
##             release/22.1.x    #1843   +/-   ##
=================================================
  Coverage                  ?   59.40%           
=================================================
  Files                     ?      510           
  Lines                     ?    21106           
  Branches                  ?     5687           
=================================================
  Hits                      ?    12537           
  Misses                    ?     8548           
  Partials                  ?       21           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216c3e5...b2f469b. Read the comment docs.

@grsoares21 grsoares21 force-pushed the feat/LIVE-545-add-ff-for-usb-fw-update-llm branch from 149561a to 764316a Compare April 27, 2022 13:33
@vercel
Copy link

vercel bot commented Apr 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ledger-live-common ❌ Failed (Inspect) May 5, 2022 at 1:32PM (UTC)

@lambertkevin lambertkevin changed the base branch from develop to release/22.1.x May 5, 2022 13:17
@valpinkman valpinkman merged commit e591e25 into release/22.1.x May 5, 2022
@valpinkman valpinkman deleted the feat/LIVE-545-add-ff-for-usb-fw-update-llm branch May 5, 2022 13:19
@lambertkevin lambertkevin mentioned this pull request May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants