-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instead of reaching 'controller' as a hostname, will need to reach '172.17.0.1' #17
Comments
@Maggie0002 not sure if I got that right: does the dev env still use "controller:9090" or does it use the new production IP as well? I can easily add a conditional to switch the hostname depending on whether the interface runs in production or not, so just need to know |
Both prod and dev will now need the ip. |
Just tried to tackle this, but I cannot reach the controller. Even just to try, I added Can you please check if it works on your side? I didn't touch anything from the controller Docker configuration in this env – just had it temporarily disabled but re-enabled it now in PR #3 |
Okay, wait – I'm an idiot. The endpoints changed and I didn't update them in the backend so obviously some of those returne a 404. 🤦♂️ Let me try again… |
Impossible for me to connect on |
To be clear: I can make the necessary changes in the dev env to get it working on dev and run tests I need to work now. The backend uses the .env file to define which URL it needs to call on the controller, so if it's not working on the dev env right now that's fine for now. We can then just test it on device by changing the env variable in the .env file |
host.docker.internal for use on Mac, 172.17.01 on Linux. |
Only works with |
Opened a ticket to document the needed production configurations as those will need to be injected as |
At the moment, the app calls the Controller API by using http://controller:9090/v1/...
This will need to change to http://172.17.0.1:9090/v1/...
This IP address will always be static, so no risk of it changing.
The difference is caused by the way the networks are setup in the production environment as opposed to the dev environment, and unfortunately we need it to run the prod way as it is required for wifi-connect to work. I have amended the dev-env to reflect the same as the prod environment so can be tested.
The text was updated successfully, but these errors were encountered: