Give L.CircleMarker.setLatLng a return statement.

[radicalbiscuit]

Ever since e5bf57c, L.CircleMarker.setLatLng has not had a return statement. The API says it's supposed to return this. This branch resolves this issue.

This should be backpatched to v0.7 as a hotfix if possible. The issue does not exist in any release prior to v0.7.

[mourner]

It's not a critical issue, so won't backpatch. Also, I'm not certain that changing the order won't break anything. It would be better to just add a return this; statement in the code.

[radicalbiscuit]

That would leave a release that doesn't match the API docs. Which, as you say, is not critical, but irksome that the documentation for the version doesn't match the behavior for the version.

I found this bug by using leaflet-locatecontrol which chains setLatLng with other L.CircleMarker functions. In that case, it halts execution along the chain since nothing is returned. I would imagine this to be a common usage scenario.

As for the order of execution, I'm not sure either. I can return the line to its previous position and add a separate return statement. But how would you feel about assigning the result of L.Circle.prototype.setLatLng.call(this, latlng) to a variable and returning that? The only reason I propose this is to preserve as much object oriented inheritance as possible.

[radicalbiscuit]

The PR has been updated. Consider my previous comment. Thanks for providing and maintaining Leaflet!

[mourner]

No need to save inherited method result to variable and return that, setters in Leaflet should always return this.