Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+1 icon #2374

Merged
merged 16 commits into from
Sep 25, 2024
Merged

+1 icon #2374

merged 16 commits into from
Sep 25, 2024

Conversation

Johny-adri2
Copy link
Contributor

@Johny-adri2 Johny-adri2 commented Sep 24, 2024

Description

rec_room

Rec Room icon addition.

Icons addition information

Added

Rec Room (com.AgainstGravity.RecRoom)

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Sep 24, 2024
Copy link
Contributor

Thanks for your contribution!

We hope that you followed the Lawnicons guidelines and made sure that Lawnicons is built correctly.

While waiting for a brief review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

@x9136
Copy link
Collaborator

x9136 commented Sep 24, 2024

The stroke width and color are correctly selected, as well as the naming. The rest is not.

I recommend reading the comment above and evaluating how the icons that have already been added are made.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Sep 24, 2024
@x9136 x9136 merged commit e1d930d into LawnchairLauncher:develop Sep 25, 2024
5 checks passed
@x9136
Copy link
Collaborator

x9136 commented Sep 25, 2024

In the new version of the icon, you decided to use the wrong stroke width. Also, the icon size remained unsuitable.

I fixed it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants