Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo cover, +3 links #2373

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Repo cover, +3 links #2373

merged 6 commits into from
Sep 25, 2024

Conversation

x9136
Copy link
Collaborator

@x9136 x9136 commented Sep 24, 2024

I add the cover so that without downloading it is clear what the app and icons look like.

#2365 Closed when syncing branches.

Linked

Snapchat (com.snapchat.android/com.snapchat.android.NorthlightAliassnapchat.svg)
Snapchat (com.snapchat.android/com.snapchat.android.SprayPaintAliassnapchat.svg)
Telegram Beta (org.telegram.messenger.beta/org.telegram.messenger.PremiumIcontelegram.svg)

Type of change

❌ Bug fix (non-breaking change which fixes an issue)
✅ General change (non-breaking change that doesn't fit the above categories, such as copyediting)

Preview

repo_cover_preview

@github-actions github-actions bot added the docs Improvements or additions to documentation label Sep 24, 2024
@x9136 x9136 marked this pull request as ready for review September 24, 2024 04:33
@x9136
Copy link
Collaborator Author

x9136 commented Sep 24, 2024

Screenshot 2024-09-24 at 07 36 14
Should be skipped after the latest changes in the workflow.

@SuperDragonXD
Copy link
Contributor

SuperDragonXD commented Sep 24, 2024

Technically, the whole workflow is skipped from running, preventing the whole PR from passing required checks. (it doesn't build the app though)

This seems to be a limitation of GitHub, where they don't allow setting a status message when a check is skipped.

We could probably use some other alternative like skip-duplicate-actions, conditional execution or something similar to make the checks "pass".

To start the workflow.
@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Sep 25, 2024
@x9136 x9136 changed the title Repo cover Repo cover, +3 links Sep 25, 2024
@x9136 x9136 merged commit 47ca824 into develop Sep 25, 2024
5 checks passed
@x9136 x9136 deleted the x9136-repo-cover branch September 25, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants