Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npy: fix parsing of complex dtypes #894

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

japm48
Copy link
Contributor

@japm48 japm48 commented Sep 14, 2024

An exported .npy file with complex single float dtype fails to be loaded with FileFormat("unrecognized descr c8") (similarly with c16 for complex double).
According to the documentation, c{size} are the only values that should be parsed as complex. I could not find any reference of F or D as introduced in #468.

@LaurentMazare
Copy link
Owner

I feel that we should keep the support for F and D just in case as it's for reading only and is not used by any other dtype. I can find some references to it here for example though it's hard to tell if it can end up in a .npy file.

@japm48
Copy link
Contributor Author

japm48 commented Sep 15, 2024

Thanks for the research. I updated the PR accordingly.

@LaurentMazare LaurentMazare merged commit 1fd7075 into LaurentMazare:main Sep 15, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants