Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RAJA plugin capability #224

Merged
merged 46 commits into from
Jul 14, 2023
Merged

Use RAJA plugin capability #224

merged 46 commits into from
Jul 14, 2023

Conversation

neelakausik
Copy link
Member

@neelakausik neelakausik commented Jun 22, 2023

CARE had custom infrastructure for doing things before and after RAJA loops. This branch moves debug and profile related code into actual RAJA plugins and makes both plugins optional. It also introduces a requirement to use CHAI's RAJA plugin to make sure data is moved to the correct execution space.

tpl/cub Outdated Show resolved Hide resolved
src/care/forall.h Outdated Show resolved Hide resolved
src/care/RAJAPlugin.cpp Outdated Show resolved Hide resolved
@neelakausik neelakausik marked this pull request as draft June 22, 2023 20:54
.radiuss-ci Outdated Show resolved Hide resolved
src/care/ProfilePlugin.h Outdated Show resolved Hide resolved
src/care/ProfilePlugin.h Outdated Show resolved Hide resolved
src/care/ProfilePlugin.h Outdated Show resolved Hide resolved
src/care/ProfilePlugin.h Outdated Show resolved Hide resolved
.radiuss-ci Outdated Show resolved Hide resolved
tpl/cub Outdated Show resolved Hide resolved
src/care/RAJAPlugin.h Outdated Show resolved Hide resolved
src/care/PluginData.h Outdated Show resolved Hide resolved
@dtaller
Copy link
Collaborator

dtaller commented Jul 11, 2023

Could you add a pull request description at the top?

@dtaller
Copy link
Collaborator

dtaller commented Jul 11, 2023

Also, care builds some internal tests (see care/test/ folder ). Do you think any tests are needed? Or would it be difficult to add unit tests for this type of feature?

src/care/PluginData.h Outdated Show resolved Hide resolved
@adayton1
Copy link
Member

Also, care builds some internal tests (see care/test/ folder ). Do you think any tests are needed? Or would it be difficult to add unit tests for this type of feature?

Testing this would require specialized infrastructure that we don't have. Since this is for debugging and profiling, I don't think it's worth trying to put in special infrastructure.

@adayton1 adayton1 changed the title plugins Use RAJA plugin capability Jul 12, 2023
@adayton1
Copy link
Member

Could you add a pull request description at the top?

I expanded on Neela's description. Let me know if it's not clear.

@dtaller
Copy link
Collaborator

dtaller commented Jul 12, 2023

Also, care builds some internal tests (see care/test/ folder ). Do you think any tests are needed? Or would it be difficult to add unit tests for this type of feature?

Testing this would require specialized infrastructure that we don't have. Since this is for debugging and profiling, I don't think it's worth trying to put in special infrastructure.

That's fine, no problem then.

Could you add a pull request description at the top?

I expanded on Neela's description. Let me know if it's not clear.

Thanks, that works for me.

@dtaller
Copy link
Collaborator

dtaller commented Jul 12, 2023

Thanks for your work!

I think that all my comments were addressed except for the alias for the strange map "using ActionMap = std::unordered_map<void *, std::function<void(chai::ExecutionSpace, const char *, int)>>". Either make the change or tell me if you ultimately decided not to do that, and then I'll approve

src/care/PluginData.h Outdated Show resolved Hide resolved
src/care/PluginData.h Outdated Show resolved Hide resolved
Copy link
Member

@adayton1 adayton1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adayton1 adayton1 merged commit 223caaa into develop Jul 14, 2023
1 check passed
@adayton1 adayton1 deleted the feature/kausik1/plugins branch July 14, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants