-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RAJA plugin capability #224
Conversation
…into feature/kausik1/plugins
Could you add a pull request description at the top? |
Also, care builds some internal tests (see care/test/ folder ). Do you think any tests are needed? Or would it be difficult to add unit tests for this type of feature? |
Testing this would require specialized infrastructure that we don't have. Since this is for debugging and profiling, I don't think it's worth trying to put in special infrastructure. |
I expanded on Neela's description. Let me know if it's not clear. |
That's fine, no problem then.
Thanks, that works for me. |
Thanks for your work! I think that all my comments were addressed except for the alias for the strange map "using ActionMap = std::unordered_map<void *, std::function<void(chai::ExecutionSpace, const char *, int)>>". Either make the change or tell me if you ultimately decided not to do that, and then I'll approve |
…into feature/kausik1/plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CARE had custom infrastructure for doing things before and after RAJA loops. This branch moves debug and profile related code into actual RAJA plugins and makes both plugins optional. It also introduces a requirement to use CHAI's RAJA plugin to make sure data is moved to the correct execution space.