Always on top feature #829
Open
+340
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGUG2Z
force-pushed
the
master
branch
2 times, most recently
from
0c842e4
to
05af7ce
Compare
|
I finished all the work I have to do so this is a PR to enable the feature to have a window always on top so when you change the workspace the always-on-top window will move with the focus workspace. This is helpful if you have multiple monitors and are focusing on a specific workspace but also want to move a window. This feature will shorten the command you have to run to achieve this. There are also different scenarios in which this command can also be handy like moving multiple windows at once. This is my first PR so if something is wrong or you want me to change something or give me criticism PLEASE DO. I hope this PR can be helpful for somebody |
This commit ensures that the "send" behaviour is respected in named-workspace command variants such as send-to-named-workspace.
This commit introduces a new SocketMessage, ReplaceConfiguration, which attempts to replace a running instance of WindowManager with another created from a (presumably) different komorebi.json file. This will likely be useful for people who have multiple different monitor setups that they connect and disconnect from throughout the day, but definitely needs more testing. An experimental sub-widget which calls this SocketMessage has been added to komorebi-bar to aid with initial testing.
LGUG2Z
force-pushed
the
master
branch
2 times, most recently
from
71aa3ce
to
96d094d
Compare
This commit introduces a new wrapper, CustomUi, which is used to implement custom methods on top of eframe::egui::Ui. The default ui::add_sized method always has the text in a label centered, which is not desirable for a status bar where the layout should be ltr. A new function CustomUi::add_sized_left_to_right has been added to ensure that labels can be truncated with a custom width (which requires allocate_ui_with_layout), while also retaining the ability for the text to be aligned to the left rather than the center of the allocated layout.
LGUG2Z
force-pushed
the
master
branch
4 times, most recently
from
e922b9a
to
24da24f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create a feature which allows a window to be always on the focused workspace. So you only need to focus the workspace I have some things still to do:
-Clean up
-Window Manager Event on Destroy and Unmanaged
a more detailed description is coming when I got everything done but I wanted to make the pull request now because I promise it in the discord chat.