Feature: label prefix on widgets #1039
Conversation
|
|
||
| #[derive(Copy, Clone, Debug, Serialize, Deserialize, JsonSchema)] | ||
| pub enum LabelPrefix { | ||
| Icon, |
There was a problem hiding this comment.
Everything looks good, let's just add some basic doc strings (/// Show an icon, /// Show text, /// Show an icon and text) here so they get picked up with the JsonSchema derive and can be shown to people using autocompletions in their editors
There was a problem hiding this comment.
Nice! I will do that.
Also I was thinking about adding a 4th option called None for the real minimalists out there. On some widgets it might make sense, like the Time and Date.
There was a problem hiding this comment.
Would you have any comments on the default values on the widgets?
Battery: Icon
Cpu: IconAndText
Date: Icon
Memory: IconAndText
Network: Icon
Storage: IconAndText
Time: Icon
I would also like to get your opinion on the text options:
Battery: BAT
Cpu: CPU
Date: DATE
Memory: RAM
Network:
-UP, DOWN,
-∑ => \u{2211}UP, \u{2211}DOWN / ∑UP, ∑DOWN or TUP, TDOWN
Storage: (just the drive letter?)
Time: TIME
LGUG2Z
force-pushed
the
master
branch
4 times, most recently
from
e922b9a
to
24da24f
Compare
I made the label prefix configurable. Show icon, text only or both.