feat: make the client more secure (see readme)

KraXen72 · May 10, 2022 · 1c8a0c3 · 1c8a0c3
1 parent 8d0775c
commit 1c8a0c3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -16,7 +16,7 @@
 - no artificial "splash screens" that increase load time, splash shows over krunker actually loading
 - *hides* ads by default (can be turned off)
 - doesen't automatically open free spin urls, prompts you before
-- doesen't disable web security
+- **secure:** `web security` is on, the `remote` module and `nodeIntegration` are disabled
 - written in typescript
 - no-compromise mac, linux and windows support
 - only 1 dependency: `esbuild` (for userscripts)

diff --git a/src/main.ts b/src/main.ts
@@ -95,7 +95,8 @@ function customGenericWin(url: string, providedMenuTemplate: (MenuItemConstructo
 		center: true,
 		webPreferences: {
 			spellcheck: false,
-			enableRemoteModule: false
+			enableRemoteModule: false,
+			nodeIntegration: false
 		}
 	});
 
@@ -172,7 +173,8 @@ app.on('ready', () => {
 		webPreferences: {
 			preload: pathJoin(__dirname, 'preload.js'),
 			enableRemoteModule: false,
-			spellcheck: false
+			spellcheck: false,
+			nodeIntegration: false
 		}
 	});