make render in jupyter use show instead

Kotlin · Apr 10, 2024 · 7fd77be · 7fd77be
1 parent e05feac
commit 7fd77be
Showing 1 changed file with 17 additions and 13 deletions.
diff --git a/jupyter/src/main/kotlin/org/jetbrains/kotlinx/spark/api/jupyter/Integration.kt b/jupyter/src/main/kotlin/org/jetbrains/kotlinx/spark/api/jupyter/Integration.kt
@@ -240,19 +240,23 @@ abstract class Integration(private val notebook: Notebook, private val options:
 
     private fun renderDataset(it: Dataset<*>): MimeTypedResult =
         with(properties) {
-            val showFunction = Dataset::class
-                .memberFunctions
-                .firstOrNull { it.name == "showString" && it.valueParameters.size == 3 }
-
-            textResult(
-                if (showFunction != null) {
-                    showFunction.call(it, displayLimit, displayTruncate, false) as String
-                } else {
-                    // if the function cannot be called, make sure it will call println instead
-                    it.show(displayLimit, displayTruncate)
-                    ""
-                }
-            )
+//            val showFunction = Dataset::class
+//                .memberFunctions
+//                .firstOrNull { it.name == "showString" && it.valueParameters.size == 3 }
+//
+//            textResult(
+//                if (showFunction != null) {
+//                    showFunction.call(it, displayLimit, displayTruncate, false) as String
+//                } else {
+//                    // if the function cannot be called, make sure it will call println instead
+//                    it.show(displayLimit, displayTruncate)
+//                    ""
+//                }
+//            )
+
+            // don't actually render, instead use `show()`, which calls System.out
+            it.show(displayLimit, displayTruncate)
+            textResult("")
         }