Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timezones #51

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add support for timezones #51

merged 1 commit into from
Feb 18, 2020

Conversation

Deuchnord
Copy link
Member

Q A
Bug fix? no
New feature? yes
Related issues Fix #45
Has BC-break no
License GNU AGPL-v3

@Deuchnord Deuchnord added the enhancement New feature or request label Feb 16, 2020
@Deuchnord Deuchnord self-assigned this Feb 16, 2020
@codecov
Copy link

codecov bot commented Feb 16, 2020

Codecov Report

Merging #51 into features will decrease coverage by 0.41%.
The diff coverage is 83.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##           features      #51      +/-   ##
============================================
- Coverage      82.3%   81.88%   -0.42%     
============================================
  Files             8        8              
  Lines           469      508      +39     
  Branches         70       81      +11     
============================================
+ Hits            386      416      +30     
- Misses           74       77       +3     
- Partials          9       15       +6
Impacted Files Coverage Δ
kosmorrolib/data.py 88.15% <100%> (ø) ⬆️
kosmorrolib/ephemerides.py 55.14% <100%> (+1.29%) ⬆️
kosmorrolib/events.py 100% <100%> (ø) ⬆️
kosmorrolib/core.py 90.9% <100%> (ø) ⬆️
kosmorrolib/dumper.py 86.76% <80%> (-2.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b19055c...d7730bd. Read the comment docs.

@Deuchnord Deuchnord force-pushed the timezone branch 2 times, most recently from 7c7d87b to bc81ce3 Compare February 16, 2020 13:36
@Deuchnord Deuchnord marked this pull request as ready for review February 16, 2020 13:42
@Deuchnord Deuchnord linked an issue Feb 16, 2020 that may be closed by this pull request
@Deuchnord
Copy link
Member Author

Deuchnord commented Feb 17, 2020

To do:

  • add the timezone information in the PDF output
  • add the date in text and PDF output when the hour with timezone applied is on the date before or after

@Deuchnord Deuchnord force-pushed the timezone branch 7 times, most recently from e3702ca to 6bfecb4 Compare February 17, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for timezones
1 participant