Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly marshal RBAC 'actions' #131

Merged
merged 1 commit into from
Feb 14, 2022
Merged

fix: correctly marshal RBAC 'actions' #131

merged 1 commit into from
Feb 14, 2022

Conversation

GGabriele
Copy link
Collaborator

As highlighted in Kong/deck#586, go-kong renders RBAC permissions as a comma-separated string..

rbac_roles:
- comment: Full access to all endpoints, across all workspaces
  endpoint_permissions:
  - actions: delete,create,read,update

...instead of an actual array:

rbac_roles:
- comment: Full access to all endpoints, across all workspaces
  endpoint_permissions:
  - actions:
    - update
    - create
    - delete
    - read

With this, deck is happy:

$ deck dump --rbac-resources-only -o permissions.yaml

$ deck sync --rbac-resources-only -s permissions.yaml
Summary:
  Created: 0
  Updated: 0
  Deleted: 0

@GGabriele GGabriele requested a review from a team as a code owner February 10, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants