Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deck@v1.29.2 library code into this repo #9

Merged
merged 3 commits into from
Nov 17, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Nov 9, 2023

Copy the konnect, cprint, crud, diff, dump, file, scripts, state, types, and utils packages from https://github.com/Kong/deck/releases/tag/v1.29.2 (also the current tip of main) into this repository's pkg dir.

Update references to those packages from their deck location to this repository.

Run:

go mod init "github.com/kong/go-database-reconciler"
go mod tidy

Add replace directive from deck go.mod.

Run:

go get github.com/alecthomas/jsonschema@v0.0.0-20191017121752-4bb6e3fae4f2
go mod tidy

This library is apparently rather out of date in deck and has had breaking changes since it was added. After this downgrade, go vet ./... no longer shows errors.

@rainest rainest requested a review from a team November 9, 2023 01:18
@rainest rainest marked this pull request as draft November 9, 2023 01:26
@rainest
Copy link
Contributor Author

rainest commented Nov 9, 2023

Between the template hook issue and lack of some lint configuration, this needs #8 first and a rebase after.

Copy the konnect, cprint, crud, diff, dump, file, scripts, state, types,
and utils packages from deck into this repository.

The source was imported from deck@v1.29.2:
https://github.com/Kong/deck/releases/tag/v1.29.2
Update import references to deck packages migrated to this repository to
use the copy in this repository instead of the original in deck.

Run:

go mod init "github.com/kong/go-database-reconciler"
go mod tidy

Add replace directive from deck go.mod.

Run:

go get github.com/alecthomas/jsonschema@v0.0.0-20191017121752-4bb6e3fae4f2
go mod tidy

This library is apparently rather out of date in deck and has had
breaking changes since it was added. After this downgrade, "go vet
./..." no longer shows errors.
@rainest rainest marked this pull request as ready for review November 13, 2023 16:45
@GGabriele GGabriele mentioned this pull request Nov 14, 2023
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@GGabriele GGabriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rainest all this is a "hard" copy of the existing decK packages, right? Is there anything specific to call out that differs from the "base" repo? Otherwise, this LGTM (preventively approving this)

@rainest
Copy link
Contributor Author

rainest commented Nov 17, 2023

It's copying the libraries as-is, yes. Only change is the package paths in internal references.

@rainest rainest merged commit 3acf39f into main Nov 17, 2023
2 of 3 checks passed
@rainest rainest deleted the chore/lift-and-shift branch November 17, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants