fix: improve lookup of consumer-groups' consumers #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
fix/consumer-group-consumers-lookup
branch
from
9c95ea9
to
7a0d9f5
Compare
This commit makes lookups for consumer-group's consumers more performant by adding indexes in the in-memory db, instead of relying on "manual" looping which is very expensive when several thousands of consumers exist.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 41.17% 41.23% +0.05%
==========================================
Files 75 75
Lines 10807 10793 -14
==========================================
Hits 4450 4450
+ Misses 5895 5881 -14
Partials 462 462 ☔ View full report in Codecov by Sentry. |
aboudreault
previously approved these changes
Jul 3, 2024
aboudreault
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes lookups for consumer-group's consumers more performant by adding indexes in the in-memory db, instead of relying on "manual" looping which is very expensive when several thousands of consumers exist.
Testing is provided by existing tests.
Summary
SUMMARY_GOES_HERE
Full changelog
Issues resolved
Fix #XXX
Documentation
Testing