Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add instance_name field to plugin schema #844

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

GGabriele
Copy link
Collaborator

No description provided.

@GGabriele GGabriele requested a review from a team February 10, 2023 19:38
@GGabriele GGabriele temporarily deployed to Configure ci February 10, 2023 19:38 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci February 13, 2023 11:02 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci February 13, 2023 11:02 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Base: 35.43% // Head: 35.41% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (f96a7a5) compared to base (deb7f55).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #844      +/-   ##
==========================================
- Coverage   35.43%   35.41%   -0.02%     
==========================================
  Files          92       92              
  Lines       11255    11261       +6     
==========================================
  Hits         3988     3988              
- Misses       6870     6875       +5     
- Partials      397      398       +1     
Impacted Files Coverage Δ
file/types.go 58.68% <0.00%> (-1.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GGabriele GGabriele temporarily deployed to Configure ci February 21, 2023 08:22 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci February 21, 2023 08:22 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci February 21, 2023 08:33 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci February 21, 2023 08:33 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci February 21, 2023 08:42 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci February 21, 2023 08:43 — with GitHub Actions Inactive
Copy link
Contributor

@aboudreault aboudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GGabriele GGabriele merged commit 31c4856 into main Feb 21, 2023
@GGabriele GGabriele deleted the feat/plugin-instance_name branch February 21, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants