fix: do not error out on EE endpoints with no license #821
Conversation
GGabriele
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
GGabriele
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
Codecov ReportBase: 35.44% // Head: 35.44% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
=======================================
Coverage 35.44% 35.44%
=======================================
Files 92 92
Lines 11245 11245
=======================================
Hits 3986 3986
Misses 6862 6862
Partials 397 397
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -248,7 +248,7 @@ func getProxyConfiguration(ctx context.Context, group *errgroup.Group, | |||
| consumerGroups, err = GetAllConsumerGroups(ctx, client, config.SelectorTags) | |||
| } | |||
| if err != nil { | |||
| if kong.IsNotFoundErr(err) { | |||
| if kong.IsNotFoundErr(err) || kong.IsForbiddenErr(err) { | |||
There was a problem hiding this comment.
since we are just returning nil will they see a warning about this too?
There was a problem hiding this comment.
They will only see the status code in verbose mode. Do you think we should log a warning too?
There was a problem hiding this comment.
could be a good idea, but we can keep this as is for this PR.
Right now decK error out when the Consumer Groups and Vaults list endpoints are hit and no license is present in the Gateway. In such case, decK should continue its flow.
GGabriele
force-pushed
the
fix/list-ee-endpoints
branch
from
148e19d
to
c03e6ac
Compare
GGabriele
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
GGabriele
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
Right now decK error out when the Consumer Groups and Vaults list endpoints are hit and no license is present in the Gateway.
In such case, decK should continue its flow.