Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): support shorthand flag for workspace #770

Closed
wants to merge 1 commit into from
Closed

feat(sync): support shorthand flag for workspace #770

wants to merge 1 commit into from

Conversation

iamnande
Copy link

Howdy 👋🏻

This PR adds the ability to use the -w shorthand for workspace on the sync command. The workspace flag on dump and diff already support the shorthand.

@iamnande iamnande requested a review from a team October 14, 2022 03:48
@CLAassistant
Copy link

CLAassistant commented Oct 14, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@iamnande iamnande temporarily deployed to Configure ci October 14, 2022 03:48 Inactive
@codecov-commenter
Copy link

Codecov Report

Base: 39.02% // Head: 39.02% // No change to project coverage 👍

Coverage data is based on head (ed071e2) compared to base (db773ae).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #770   +/-   ##
=======================================
  Coverage   39.02%   39.02%           
=======================================
  Files          88       88           
  Lines       10105    10105           
=======================================
  Hits         3943     3943           
  Misses       5777     5777           
  Partials      385      385           
Impacted Files Coverage Δ
cmd/sync.go 0.00% <0.00%> (ø)
cmd/common_konnect.go 7.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GGabriele
Copy link
Collaborator

Hey @iamnande , thanks for the contribution!

This same fix has been merged a couple of days ago and it's not in main. Not sure why Github shows a change on our main 🤔

@iamnande iamnande closed this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants