fix: remove all selected tags when using dump #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
fix/no-tags-on-entities
branch
from
24c74ae
to
2da5144
Compare
GGabriele
force-pushed
the
fix/no-tags-on-entities
branch
from
2da5144
to
7d8d4f7
Compare
aboudreault
previously approved these changes
Oct 18, 2022
GGabriele
force-pushed
the
fix/no-tags-on-entities
branch
from
7d8d4f7
to
892ac4b
Compare
The expected behaviour for `deck dump` when using `--select-tag`
is the following:
1. selected tags information should be summarized at the top of
the configuration file inside the `_info` structure
2. selected tags must be removed from entity-level tags
Right now decK doesn't perform (2) consistently, stripping out
selected tags from some entities, but not from some others.
For example:
```
$ deck dump --select-tag test-tag --yes
$ cat kong.yaml
_format_version: "3.0"
_info:
defaults: {}
select_tags:
- test-tag
services:
- connect_timeout: 60000
enabled: true
host: mockbin.org
name: svc1
port: 80
protocol: http
read_timeout: 60000
retries: 5
routes:
- https_redirect_status_code: 301
name: r1
path_handling: v0
paths:
- /r1
preserve_host: false
protocols:
- http
- https
regex_priority: 0
request_buffering: true
response_buffering: true
strip_path: true
tags:
- another-test-tag
tags:
- test-tag
write_timeout: 60000
```
Here, `test-tag` is correctly stripped out from the route
entity, which now has only the `another-test-tag` tag, but the
`test-tag` is still included in the service entity.
This PR makes sure that selected tags are removed from all
entities, so that this information will only be included in the
`_info` structure.
GGabriele
force-pushed
the
fix/no-tags-on-entities
branch
from
892ac4b
to
935adeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expected behaviour for
deck dumpwhen using--select-tagis the following:_infostructureRight now decK doesn't perform (2) consistently, stripping out selected tags from some entities, but not from some others. For example:
Here,
test-tagis correctly stripped out from the route entity, which now has only theanother-test-tagtag, but thetest-tagis still included in the service entity.This PR makes sure that selected tags are removed from all entities, so that this information will only be included in the
_infostructure.