-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/format version 3.0 #753
Conversation
db7331b
to
a139df4
Compare
Codecov Report
@@ Coverage Diff @@
## main #753 +/- ##
==========================================
- Coverage 39.98% 39.81% -0.18%
==========================================
Files 87 87
Lines 9715 9834 +119
==========================================
+ Hits 3885 3915 +30
- Misses 5459 5543 +84
- Partials 371 376 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
b0c808d
to
9ac13e4
Compare
9ac13e4
to
28bd040
Compare
28bd040
to
e385db0
Compare
e385db0
to
8dff2bd
Compare
de6168c
to
68bed9d
Compare
68bed9d
to
fa28485
Compare
abcdf77
to
0595083
Compare
Before this change, the "1.1" format version was hardcoded when `deck dump` was ran. Now deck: - sets `_format_version: 1.1` with Kong < 3.x - sets `_format_version: 3.0` with Kong >= 3.x
0595083
to
cf4e8a0
Compare
cf4e8a0
to
38208a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a product perspective.
convert/convert.go
Outdated
cprint.UpdatePrintf( | ||
"From the '%s' config file,\n"+ | ||
"%d unsupported routes' paths format with Kong version 3.0\n"+ | ||
"or above were detected, including:\n\n"+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"or above were detected, including:\n\n"+ | |
"or above were detected, Some of these routes are (not an exhaustive list):\n\n"+ |
utils/utils.go
Outdated
} | ||
cprint.UpdatePrintf( | ||
"%d unsupported routes' paths format with Kong version 3.0\n"+ | ||
"or above were detected, including:\n\n"+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
38208a3
to
53d1f52
Compare
No description provided.