fix: diff with not-existing WS must not fail due to defaults #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decK dynamically discovers entities defaults by interacting with the Kong Admin API. Queries to retrieve entities schema for a workspace that doesn't exist yet would fail though. When running `diff`, in order to prevent a failure, decK simply skips defaults injection for all entities, but it was still wrongly running queries for plugins, making the run fail. This PR makes sure plugins defaults injection is treated the same as other entities when running `diff` against a not-existing workspace.
Codecov Report
@@ Coverage Diff @@
## main #702 +/- ##
==========================================
- Coverage 43.50% 43.49% -0.01%
==========================================
Files 74 74
Lines 8923 8925 +2
==========================================
Hits 3882 3882
- Misses 4671 4673 +2
Partials 370 370
Continue to review full report at Codecov.
|
rainest
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decK dynamically discovers entities defaults by interacting
with the Kong Admin API. Queries to retrieve entities schema
for a workspace that doesn't exist yet would fail though.
When running
diff, in order to prevent a failure, decK simplyskips defaults injection for all entities, but it was still
wrongly running queries for plugins, making the run fail.
This PR makes sure plugins defaults injection is treated the
same as other entities when running
diffagainst anot-existing workspace.
Solves #697