feat: inject deck version into User-Agent header #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbagdi
reviewed
Apr 21, 2022
cmd/root.go
Outdated
|
|
||
| func extendHeaders(headers []string) []string { | ||
| userAgentHeader := fmt.Sprintf( | ||
| "User-Agent:decK/%s (%s) %s", VERSION, COMMIT, runtime.Version(), |
There was a problem hiding this comment.
Can we skip COMMIT for now?
Suggested change
| "User-Agent:decK/%s (%s) %s", VERSION, COMMIT, runtime.Version(), | |
| "User-Agent:decK/%s", VERSION, |
Codecov Report
@@ Coverage Diff @@
## main #652 +/- ##
==========================================
- Coverage 44.39% 44.37% -0.03%
==========================================
Files 74 74
Lines 8774 8778 +4
==========================================
Hits 3895 3895
- Misses 4518 4522 +4
Partials 361 361
Continue to review full report at Codecov.
|
Before this change: ``` $ deck ping <-- kong logs --> 172.19.0.1 - "GET / HTTP/1.1" 200 17479 "-" "Go-http-client/1.1" ``` After this change: ``` $ deck ping <-- kong logs --> 172.19.0.1 - "GET / HTTP/1.1" 200 17479 "-" "decK/v1.11.0" ```
GGabriele
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change:
After this change: